Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session expire date parsing #104

Closed
wants to merge 2 commits into from
Closed

Conversation

Titotix
Copy link
Contributor

@Titotix Titotix commented Jun 11, 2021

No description provided.

@Titotix Titotix marked this pull request as draft June 11, 2021 07:45
@Titotix Titotix mentioned this pull request Jun 11, 2021
@zamzterz
Copy link
Owner

Thanks for your contribution - great start! 👍

As mentioned in #106, it would be fine to drop testing against Python 3.5 in this PR. And it would be great to also combine it with #105 to get the tests passing again with a single PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #104 (6adc1ca) into master (ab0e9b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files           9        9           
  Lines         591      591           
  Branches       61       61           
=======================================
  Hits          579      579           
  Misses          7        7           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e9b3...6adc1ca. Read the comment docs.

@Titotix
Copy link
Contributor Author

Titotix commented Jun 15, 2021

I had a commit to drop Python3.5 support.
But this #105 doesn't fix anything actually, it was to test if the upgrade of pip was enough to fix the missing Rust compiler for cryptography lib but it is not and I did not dig more in it. According to the cryptography doc :

If you are on RHEL/CentOS/Fedora/Debian/Ubuntu or another distribution derived from the preceding list, then you should upgrade pip (in a virtual environment!) and attempt to install cryptography again before trying to install the Rust toolchain. These platforms will receive a binary wheel and require no compiler if you have an updated pip!

But I am not used to travis and I didn't look for which platform it uses to run the test.

@zamzterz
Copy link
Owner

After a closer look, and combining your 2 PRs with a small addition the tests are now working again.
I took the liberty of creating a PR out of that which I'd be happy if you took a quick look at: #107

@zamzterz zamzterz closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants