Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the signed ID Token in user session. #32

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Conversation

zamzterz
Copy link
Owner

Previously the real signature was removed, and a plain (unsigned) JWT
containing the same claims as the original ID Token was stored in the
session. This prevented it from being properly validated when forwarded
as 'id_token_hint' in logout requests.

@codecov-io
Copy link

codecov-io commented Sep 25, 2018

Codecov Report

Merging #32 into master will decrease coverage by 0.24%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   95.93%   95.69%   -0.25%     
==========================================
  Files           6        6              
  Lines         394      395       +1     
  Branches       39       40       +1     
==========================================
  Hits          378      378              
  Misses          7        7              
- Partials        9       10       +1
Impacted Files Coverage Δ
src/flask_pyoidc/flask_pyoidc.py 89.76% <100%> (-0.16%) ⬇️
src/flask_pyoidc/pyoidc_facade.py 98.63% <75%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ff1a5...ea97af2. Read the comment docs.

Previously the real signature was removed, and a plain (unsigned) JWT
containing the same claims as the original ID Token was stored in the
session. This prevented it from being properly validated when forwarded
as 'id_token_hint' in logout requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants