Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regressive delete problem with roku UP after delete #18

Open
rshendershot opened this issue Jun 2, 2013 · 4 comments
Open

regressive delete problem with roku UP after delete #18

rshendershot opened this issue Jun 2, 2013 · 4 comments

Comments

@rshendershot
Copy link

this may have been fixed but due to Issue #16 I can't try it. It would be a big problem in a channel release.

When I delete I'm returned to categories[0] in the main screen. I wish this was the top level menu instead, but... I press the Roku UP key and am presented with the detail screen of the show I just deleted. If I chose delete then some other show will unexpectedly be deleted.

after Delete we need to more carefully re-initialize internal data

@rshendershot
Copy link
Author

after deleting, clicking the UP brings up the deleted detail. choosing delete again causes an illegal reference and my Roku drops into debug. (zane-master 20130605)

zane131 added a commit that referenced this issue Jun 27, 2013
@zane131
Copy link
Owner

zane131 commented Jun 27, 2013

I implemented a fix for this issue. I should note that users may experience some quirkiness with the pagination. Nothing serious. Just that a video may be repeated from one page of the list to the next. Simply hitting back/up and reselecting the directory will refresh the list and the pages. I thought about fixing the issue but it appears to be a fairly pervasive fix and I would rather spend my time refactoring the UI. So I think I will mark that issue as an acceptable risk for now.

zane131 added a commit that referenced this issue Jul 2, 2013
@rshendershot
Copy link
Author

deleted all recordings in Recordings/Filesystem menu view. clicked Up, Up and player froze. could not exit Recordings menu.

url: http://192.168.1.50/mythweb/mythroku/mythtv_tv_del.php?basename=1912_20130103143500.mp4
[showDetailScreen] Screen closed
BEGIN load_show_feed -----------------------------------------------
url: http://192.168.1.50/mythweb/mythroku/mythtv_xml.php?type=rec&sort%5Btype%5D=channel
Request Time: 21
no feed body found

@zane131
Copy link
Owner

zane131 commented Jul 4, 2013

The problem is that when traversing backwards though the screens the UI needs to refresh every screen in the stack. This is not an easy fix because of the way the UI is designed (mostly because it is based on the SDK videoplayer example. I need to think about this some more.

zane131 added a commit that referenced this issue Jul 5, 2013
zane131 added a commit that referenced this issue Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants