-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 3 tables categories, categories_proposals, and proposals the sa… #39
base: master
Are you sure you want to change the base?
Conversation
e0a6e2f
to
d09ae99
Compare
abb0f75
to
049cd31
Compare
submitted changes. But still need to figure certain things. |
049cd31
to
882cec6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to remove the 'wallet_address' field from the Users table and just have one wallet address for the user defined from the recovery words
Does that mean the user will only be using one wallet_address? ie. their merchant_app seed would be the same as the seed thats being stored in merchat_server? |
yes |
I'm going to need a version of the merchant app that recognizes the qrcode. At the moment, when scan using the merchant app, its giving me invalid qrcode. Also need to do do the following to get user.wallet_address out of the db. Currently, seeing the following:
Which appears to being used in the MerchantTxModelView.
need to figure a way to remove the user.wallet_address without getting affected. Actually, this appears for updating. The question is whether its being left black then updated or if its being updated by something before it gets through this process. |
did a test by creating new account and new wallet. and it looks like when scanning the qrcode this is setting the wallet_address in the "User" table. Still investigating to see what could be writing this "User".wallet_address and change it somehow. |
I can't see what's writing the "User".wallet_address, its leading me to believe that this is being triggered by the merchant app, rather that the merchant server. If thats true, all I need to do is to remove the rebate_address on the "information" column on the "User" table. but since we are have to generate the wallet_address from the seed and put it in the "User" table, need more trying to figure out how to do that. |
882cec6
to
5ccf42e
Compare
done the following:
after_model_change. So this meant that we don't necessarily need to scan the api-key qrcode to populate the User.wallet_address. Not sure, what else the api-key qrcode does or if the function that does it, does other things apart from populating the User.wallet_address field. The User.wallet_address field is also used for the MerchantTx. Looks like its populating the table with the transactions for the merchant. So I need to look at and see if I can make this into looking at moving it away from the User.wallet_address to Seeds.wallet_address,etc...... |
noticed something funky with the emrchant app. the amount of zap that you send when placing the nzd value is weird. currently the server is setup for the customer_rate of 8%. getting the following:
NZD * 100 + (customer_rate + transaction_fee) |
…ls the same as zapd. seed table added as well. initial test for sending from invidividual wallets works. Removed teh commented lines i could find. Also still trying to figure out how to change the create_view for the Proposal, wanted it to check to make sure that the Seeds.wallet_seed is not empty.
5ccf42e
to
0895dd4
Compare
…me as zapd.
Copied the mainnet proposals screen. Not complete. It's not sending email notifications at the moment. Not sure how we sending the rebates, needs clarification.