Massive refactor and a bug fix

[mamaraddio]

I tried to refactor the zap codebase

• Starting with install.zsh:
  • Simply refactored the code
  • Add a check that resolves Check if zap is already installed #75 , thanks to @Senpai-10
• next in completion/_zap:
  • used a more simple way to define completion
  • changed flagged options (example zap --update) to subcommands (example zap update)
• finally in zap.zsh:
  • a huge code refactor and (in my opinion) a small quality improvement
  • added return values on errors
  • removed the use of installed_plugins file (thus avoiding issue no such file or directory: /home/$USER/.local/share/zap/installed_plugins #89), now the installed plugins are stored in a zsh indexed array
  • refactored _try_source and plug functions
  • refactored _pull and _zap_update to avoid endless cd through directories
  • refactored _zap_clean to fetch the new $ZAP_INSTALLED_PLUGINS array (rather than looking for a file)
  • when answering Y or N to zap clean, now it reads the answer without having to confirm with ENTER (i think it's better)
  • zap help doesn't need an additional file anymore
  • zap version now shows version tag, branch and commit hash
  • refactored zap function to fetch previous changes

[wintermi]

Just entering the command zap returns Invalid option, see "zap help", could we not default to the same output as zap help. Which is what the current release does.

[wintermi]

Executing the zap update command, I noticed that first line is out of alignment.

 0  ⚡ Zap
1  🔌 zsh-autosuggestions
2  🔌 zsh-syntax-highlighting
3  🔌 zsh-autopair

[wintermi]

When executing a zap update command, entering 0 to update itself, I get the following output:

🔌 Plugin Number | (a) All Plugins | (0) ⚡ Zap Itself: 0
⚡ zap updated!
⚡ plugins updated!

What plugins was updated?

[mamaraddio]

When executing a zap update command, entering 0 to update itself, I get the following output:

🔌 Plugin Number | (a) All Plugins | (0) ⚡ Zap Itself: 0
⚡ zap updated!
⚡ plugins updated!

What plugins was updated?

Let me try

[mamaraddio]

Fixed both alignment and updating zap itself

[mamaraddio]

Please, continue let me know if new bugs pop up

[wintermi]

After the latest commit, I am no longer able to update "All Plugins", when I enter in a it updates Zap iteself only.

[mamaraddio]

After the latest commit, I am no longer able to update "All Plugins", when I enter in a it updates Zap iteself only.

I go work to a different approach to try solve this, thanks again for being my "beta tester" 🙂

[mamaraddio]

Let's test again please 🙏

[wintermi]

All tests were successful.