Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cater for sourcing local plugin directories #114

Merged
merged 3 commits into from
Feb 15, 2023
Merged

feat: cater for sourcing local plugin directories #114

merged 3 commits into from
Feb 15, 2023

Conversation

wintermi
Copy link
Contributor

@wintermi wintermi commented Feb 7, 2023

  • Add examples of sourcing local ZSH files via the Zap plug function to the README
  • Enhance to allow the activating of local plugin directories

@mamaraddio
Copy link
Member

mamaraddio commented Feb 7, 2023

For the "activating local plugin directories", the code looks fine.

The usage o this feature leads to the necessity of cloning a repo without managing it with Zap
(or creating a folder with a plugin file inside), and then pass the dir path to plug.
So, why not just passing the path to the plugin?

I just want let @ChristianChiarulli to decide for this feature, personally I think is not a tragedy to provide a full path to the plugin instead of the directory name, but if this is accepted by Chris I have no reasons to disagree.

@wintermi
Copy link
Contributor Author

wintermi commented Feb 9, 2023

No worries, I just thought it would be a nice option to help plugin developers using Zap.

@ChristianChiarulli
Copy link
Member

hmm I thought we already had the functionality to source local zsh files

@wintermi wintermi merged commit 00c6e30 into zap-zsh:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants