Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace user config with default zap config #122

Merged
merged 13 commits into from
Apr 13, 2023

Conversation

ChristianChiarulli
Copy link
Member

No description provided.

@ChristianChiarulli ChristianChiarulli changed the title Create zshrc if not present feat: replace user config with default zap config Apr 3, 2023
install.zsh Outdated Show resolved Hide resolved
touch "$ZSHRC"
fi

echo "# Created by Zap installer" >> "$ZSHRC"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than multiple echo lines, would it be easier to maintain the "default zap config" as a seperate file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I think that's a good idea

install.zsh Show resolved Hide resolved
Copy link
Member

@mamaraddio mamaraddio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


    return 0
}

main $@
[[ $? -eq 0 ]] && exec zsh || return

# vim: ft=zsh ts=4 et

This should address the TODO

@ChristianChiarulli ChristianChiarulli merged commit e112159 into master Apr 13, 2023
1 check passed
@ChristianChiarulli ChristianChiarulli deleted the create-zshrc-if-not-present branch April 18, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants