Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update zap version output to include latest tag version number #149

Merged
merged 3 commits into from
May 14, 2023

Conversation

wintermi
Copy link
Contributor

  • feat: update zap version output to include latest tag version number
  • fix: modify install script to perform a full git clone, to ensure tag information is present

image

@wintermi wintermi requested a review from mamaraddio May 14, 2023 05:56
@wintermi
Copy link
Contributor Author

Output after simplification and using non-bold colours

image

@mamaraddio
Copy link
Member

I fully agree with this changes, just want to remember that this is in contrast with #129 and #130.

With that said I fully agree to clone the whole repo that is only 138KB

@wintermi
Copy link
Contributor Author

wintermi commented May 14, 2023

Plugin's are still cloned with a depth of 1, only the install of Zap itself will do the full clone.

If we could guarantee that a tag would always be assigned to the release-v1 branch last commit, then this would not be required. Though this may be difficult if not automated.

@ChristianChiarulli
Copy link
Member

yea I think it's worth it in this case, it's not like we're saving media or 100 plugins in the repo.

@wintermi wintermi merged commit 002de7a into master May 14, 2023
7 checks passed
@wintermi wintermi deleted the wintermi branch May 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants