Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Plugin Installation From User #4

Merged
merged 10 commits into from
Nov 6, 2022

Conversation

Pheon-Dev
Copy link
Contributor

@Pheon-Dev Pheon-Dev commented Nov 6, 2022

Hiding the clone output from users during installation and showing what plugins are being installed instead. (Still refining)
Picture

README.md Outdated
@@ -33,7 +33,7 @@ Zap is a minimal `zsh` plugin manager
## Install

```sh
sh <(curl -s https://raw.githubusercontent.com/zap-zsh/zap/master/install.sh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org name change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

install.sh Outdated
@@ -1,6 +1,6 @@
#!/bin/sh

git clone https://github.com/zap-zsh/zap.git "$HOME/.local/share/zap"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org name change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ChristianChiarulli
Copy link
Member

can we try using a lighting bolt instead of a checkmark?

Copy link
Member

@ChristianChiarulli ChristianChiarulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added you to the org btw if interested

@ChristianChiarulli ChristianChiarulli merged commit be01eab into zap-zsh:master Nov 6, 2022
@Pheon-Dev
Copy link
Contributor Author

Thanks, much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants