Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler flag options for zap command #50

Merged
merged 11 commits into from
Nov 12, 2022

Conversation

Pheon-Dev
Copy link
Contributor

@Pheon-Dev Pheon-Dev commented Nov 12, 2022

Issues: #46 for flags & #43 for blank plugins due to commenting

$ zap --update
$ zap -u
...

Copy link
Member

@ChristianChiarulli ChristianChiarulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to namespace the functions for example:

_zap_update

@Pheon-Dev Pheon-Dev changed the title Simpler glag options for zap command Simpler flag options for zap command Nov 12, 2022
@Pheon-Dev
Copy link
Contributor Author

Okay cool working on renaming the functions

zap.zsh Outdated Show resolved Hide resolved
@Granddave
Copy link
Member

Nice PR 👍

zap.zsh Outdated Show resolved Hide resolved
@ChristianChiarulli
Copy link
Member

running zap -d and then zap -a the deactivated plugin doesn't show up in the list to activate

@Pheon-Dev
Copy link
Contributor Author

Pheon-Dev commented Nov 12, 2022

Fixed it @ChristianChiarulli

It was still using the old commenting style #plug instead of # plug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants