Feat/don't ask unneeded input on (de)activate #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all plugins are active, trying to active shouldn't do anything. Similarly for deactive and remove. Fixes zap-zsh#53
A lot of people use dotfile repos and create symlinks, follow them and change source instead of breaking the link
|
looks good, pls fix merge conflicts |
…eded-input Solve merge conflicts
|
Done 👍 Really strange conflict as it was complaining on a line I didn't touch. I solve it with merge, but if we prefer rebase let me know and I'll adapt that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added
--follow-symlinksto thesedcommands.A lot of people use dotfile repos and create symlinks. I think it makes more sense to have the original changed than to break the link (the backup is still created).
I was making changes to my
.zshrcin my repo and nothing was being picked up as the link broke, it was quite confusing .