Misc features and fixes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granddave
force-pushed
the
variable-cleanup
branch
from
a5f6bb3
to
75c7c4d
Compare
ChristianChiarulli
approved these changes
Nov 7, 2022
This lowers the risk of typos as well as exposing the plugin directory to the user via the environment variable. The `ZAP_` prefix could be used for other variables as well in the future.
We don't want the internal variables to be available outside of the function scope, so let's mark them as local. Note: We might want to change the shebang to point to bash or zsh instead of plain sh since some of the things in this script isn't POSIX compliant.
Grep complained that the .zshrc file didn't exist when I tried to run the installer in a clean Docker environment. The `touch` makes sure to create the file if it doesn't already exist.
Granddave
force-pushed
the
variable-cleanup
branch
from
75c7c4d
to
d113e6e
Compare
|
Rebased on top of master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup of the variables.
I mentioned in some commit that we might want to change from using
#!/bin/shto either bash or zsh since some language features that we currently use aren't POSIX compliant. Maybe go for Zsh?