Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mock response to be extended as well #2

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Allow mock response to be extended as well #2

merged 1 commit into from
Oct 4, 2019

Conversation

bwhitty
Copy link
Contributor

@bwhitty bwhitty commented Oct 4, 2019

Firstly, thanks for this package!

This change is pretty simple: allow the mock response to be extended the same as mock request can be.

Adds a new optional extendMockResponse parameter to createTestClient.

vitorbal
vitorbal approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@vitorbal vitorbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwhitty thanks, this makes sense to me 👍 appreciate the doc updates as well 🙇

@vitorbal vitorbal merged commit 2671b52 into zapier:master Oct 4, 2019
@vitorbal vitorbal added the enhancement New feature or request label Oct 4, 2019
@vitorbal
Copy link
Contributor

vitorbal commented Oct 4, 2019

Published as apollo-server-integration-testing@2.2.0.

@bwhitty
Copy link
Contributor Author

bwhitty commented Oct 4, 2019

You're welcome, and thanks for the quick action @vitorbal!

@bwhitty bwhitty deleted the customize-context-response branch August 4, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorbal vitorbal vitorbal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwhitty @vitorbal