Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Bugfix: Non ascii-chars in user name #24

Merged
merged 2 commits into from Mar 8, 2012
Merged

Conversation

kjona
Copy link
Contributor

@kjona kjona commented Mar 8, 2012

First and last names of users were treated as non-unicode strings. This lead the application to stop working (decode error) if a user with non-ascii name saved a question.
I added two characters to fix this problem - declaring strings as unicode were the user lastname/firstname are read.

PS: Sorry for two separate commits - its the first time I use github ;-)
PPS: Thank you for your work. I really like it.

bryanhelmig added a commit that referenced this pull request Mar 8, 2012
Bugfix: Non ascii-chars in user name
@bryanhelmig bryanhelmig merged commit 75f17b7 into zapier:master Mar 8, 2012
@bryanhelmig
Copy link
Member

Wonderful, thanks @kjona! I've merged this in. You may add yourself to the authors/contributors list as well if you like. I'll gladly pull that in.

@kjona
Copy link
Contributor Author

kjona commented Mar 14, 2012

Thank you for your quick response and the invitation to the contributors list. However, the changes are only two characters - I'll join the list with the next improvement :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants