Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore the 403 returned from argocd when creating new app #187

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented Apr 8, 2024

argocd returns 403 if an app doesn't exist; this logic was just wrong

argocd returns 403 if an app doesn't exist; this logic was just wrong
Copy link

github-actions bot commented Apr 8, 2024

Temporary image deleted.

Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djeebus djeebus merged commit 1002f98 into main Apr 11, 2024
5 checks passed
@djeebus djeebus deleted the fix-adding-apps branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants