This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Use path.join to form windows-compatible path #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also looks like this check won't work on Windows: zapier-platform-cli/src/utils/build.js Line 116 in 6156a43 |
BrunoBernardino
approved these changes
Aug 21, 2017
|
@BrunoBernardino what do you think about zapier-platform-cli/src/utils/build.js Line 116 in 6156a43 |
|
I think that makes sense! |
FokkeZB
commented
Aug 21, 2017
| @@ -113,7 +113,7 @@ const forceIncludeDumbPath = (filePath/*, smartPaths*/) => { | |||
| // we include smartPaths just incase you want to check the inclusion of some library | |||
| return ( | |||
| (filePath.endsWith('package.json') || filePath.endsWith('definition.json')) | |||
| || filePath.match(/aws-sdk\/apis\/.*\.json/) | |||
| || filePath.match(path.sep === '\\' ? /aws-sdk\\apis\\.*\.json/ : /aws-sdk\/apis\/.*\.json/) | |||
There was a problem hiding this comment.
@BrunoBernardino since Travis doesn't support Windows (yet) it's hard to add a test, but I've tested this logic in Parallels:
There was a problem hiding this comment.
Sounds good enough to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this causes:
https://secure.helpscout.net/conversation/415601400/628033/?folderId=20363#thread-1123745601
But still good practice not to use os-specific path separator.