This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
fix: exit code 1 for only for errors #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ifedapoolarewaju can you please sign the CLA so we can merge this? |
|
@BrunoBernardino done! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
zapier testis run, it terminates with exit code 1, when just warnings are returned during style check validation. Warnings are not critical IMHO. This behaviour breaks builds indiscriminately, even when the warning doesn't necessarily apply to the project.A current work around is to run with
--skip-validate, but then this takes away other benefits of running the validation, like identifying actual errors for example.This PR changes the behavior to only terminate with exit code 1 for actual errors and not warnings. :)