This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
zapier convert: Escape special chars in field help text #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eliangcs
commented
Nov 14, 2017
eliangcs
commented
- Fix redundant slashes when escaping line breaks
- Escape single quotes (')
* Fix redundant slashes when escaping line breaks
* Escape single quotes (')
| const field = s2js(string); | ||
| field.helpText.should.eql('line 1\\nline 2\\nline 3\\n'); | ||
| field.helpText.should.eql('line 1\nline 2\nline 3\n'); |
There was a problem hiding this comment.
Doesn't this mean the converted helpText will keep the newlines (which will be a problem when we print them in the template)?
There was a problem hiding this comment.
That's what I thought when I wrote 'line 1\\nline 2\\nline 3\\n' originally in this test. But since we eval string with s2js to an object, the escaped newlines in the template are unescaped again.
For example:
> eval("({helpText: 'line 1\\nline 2'})");
{ helpText: 'line 1\nline 2' }
Try zapier convert an app that uses multi-lines help text and you'll see how this PR fixes the issue.
There was a problem hiding this comment.
I see how that makes sense.
BrunoBernardino
approved these changes
Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.