Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

zapier convert: Normalize newlines in scripting #183

Merged
merged 2 commits into from
Nov 14, 2017
Merged

zapier convert: Normalize newlines in scripting #183

merged 2 commits into from
Nov 14, 2017

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Nov 14, 2017 •
edited
Loading

This PR normalizes all the newline characters to \n if user uses \r\n or \r as newlines in their JavaScript scripting.

BrunoBernardino
BrunoBernardino approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@BrunoBernardino BrunoBernardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

I didn't know this was a possibility. I thought we cleaned it up when saving on Zapier's end.

@BrunoBernardino
Copy link
Contributor

BTW, If we could add a small little test for this, it'd be great.

@eliangcs
Copy link
Member Author

Good idea! Added tests in e5848cf.

@eliangcs eliangcs merged commit 17d0812 into master Nov 14, 2017
@BrunoBernardino BrunoBernardino deleted the convert-scripting-newlines branch November 14, 2017 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoBernardino BrunoBernardino BrunoBernardino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliangcs @BrunoBernardino