This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Adding explanation about uppercase env vars #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when they're set with `zapier env`. [Relevant Trello Card](https://trello.com/c/Z6qXyRtT/202-suggestions-for-improvements-to-cli)
BrunoBernardino
commented
Nov 30, 2017
| @@ -601,7 +601,7 @@ <h2 id="env">env</h2> | |||
| <div class="row-height"> | |||
| <div class="col-md-5 col-sm-12 col-height docs-primary"> | |||
| <blockquote> | |||
| <p>Read and write environment variables.</p> | |||
| <p>Read, write, and delete environment variables.</p> | |||
There was a problem hiding this comment.
Apparently I forgot to npm run docs for another merged PR. 🙊
eliangcs
suggested changes
Dec 4, 2017
README-source.md
Outdated
| @@ -695,6 +695,8 @@ should('some tests', () => { | |||
|
|
|||
| > This is a popular way to provide `process.env.ACCESS_TOKEN || bundle.authData.access_token` for convenient testing. | |||
|
|
|||
| > **NOTE** Variables defined via `zapier env` will _always_ be stored and accessed in uppercase format. | |||
|
|
|||
There was a problem hiding this comment.
I would be more specific by saying something like:
... will be uppercased. For example, you would access the variable defined by
zapier env 1.0.0 foo_bar 1234withprocess.env.FOO_BAR.
|
Alright, please check it out @eliangcs ! |
eliangcs
approved these changes
Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For when they're set with
zapier env.Relevant Trello Card