This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Fix issue where calls to utils.printData hangs #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running utils.printData on a headless terminal (such as a CI) or a "skinny" terminal window, the call would hang indefinitely. The call was getting into a never-ending while-loop because the calculated window space was too small for output. Instead of going into that while-loop, if the calculated window space is too small, the printData call will switch from row output to plain output.
xavdid
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
Awesome, works great!
As a point of order, make sure to claim the corresponding jira ticket before you work on stuff. We want to make sure we're not repeating work! You know there's a ticket because ZapZaplar commented on the external issue.
|
D'oh! I saw the comment but I didn't realize it meant Jira. Got it for the future. Thanks! |
|
No problem at all! Anyway, looks great. go ahead and merge it when you're ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279
When calls to
utils.printDatawere made on a headless machine (such as a CI) or a "skinny" terminal (with a column width less than a certain amount of columns - 15 would always do it), the call would get stuck in a while loop. To make a long story short, this loop was lopping off text based on how many columns we had calculated were available for use. But when the calculated width was non-positive, the text-lopping never ended because we were saying ~'drop the first -6 characters of "example"'.Now, when the calculated width is non-positive, the entire while-loop is avoided by directly returning the
makePlaincall.As a bonus, this should fix an old test that was marked skipped. :)