This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Fix bug where deasync binary isn't in Windows build #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
approved these changes
Oct 24, 2018
src/utils/build.js
Outdated
| filePath.endsWith(`/bin/linux-x64-node-${nodeMajorVersion}/deasync.node`) || // Special, for zapier-platform-legacy-scripting-runner | ||
| filePath.endsWith( | ||
| // Special, for zapier-platform-legacy-scripting-runner | ||
| path.sep === '\\' |
There was a problem hiding this comment.
You can change this whole ternary to use path.join, which takes care of detecting and using the separator correctly. Same goes for above, and basically any other use of path.sep.
filePath.endsWith(path.join('bin', `linux-x64-node-${nodeMajorVersion}`, 'deasync.node'))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369.