This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
use async // await in build #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
suggested changes
Dec 20, 2018
src/utils/build.js
Outdated
| 'node_modules', | ||
| constants.PLATFORM_PACKAGE | ||
| ); | ||
| if (!await fs.exists(corePath)) { |
There was a problem hiding this comment.
Suggested change
| if (!await fs.exists(corePath)) { | |
| if (!fs.existsSync(corePath)) { |
We need to use fs.existsSync here because fs.exists is a callback-style function (rather than promise-style) and deprecated.
src/utils/build.js
Outdated
| return {}; // TODO err, what should we do on windows? | ||
| const fileWriteError = await writeFile( | ||
| `${tmpDir}/definition.json`, | ||
| prettyJSONstringify(rawDefinition.results) |
There was a problem hiding this comment.
I think you meant to write
Suggested change
| prettyJSONstringify(rawDefinition.results) | |
| prettyJSONstringify(rawDefinition) |
because .results has been done previously.
| 'zapier-' + crypto.randomBytes(4).toString('hex') | ||
| ); | ||
|
|
||
| const maybeNotifyAboutOutdated = () => { |
| wdir = wdir || process.cwd(); | ||
| zipPath = zipPath || constants.BUILD_PATH; | ||
| sourceZipPath = sourceZipPath || constants.SOURCE_PATH; | ||
| const osTmpDir = await fse.realpath(os.tmpdir()); |
There was a problem hiding this comment.
Suggested change
| const osTmpDir = await fse.realpath(os.tmpdir()); | |
| const osTmpDir = fse.realpathSync(os.tmpdir()); |
This needs to be sync version as fs.realpath is a callback-style function.
There was a problem hiding this comment.
I think this one's ok, since it's using fs-extra, which makes everything into promises.
There was a problem hiding this comment.
Yeah! If we had been using fs, you'd be correct, but the whole point of fs-extra is that all the async methods are promise-baed.
|
I think we're good on the |
eliangcs
approved these changes
Dec 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally started this as an improvement to
source.zipgeneration (namely, always excluding node_modules) but got distracted and inspired by your PR yesterday that I wanted to do the same. I'll get to that another day.No functionality should have changed - this is purely a rewrite using async and await.