Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Update doc to reflect outputFields current reality #386

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Jan 8, 2019

Fixes #384.

FieldSchema doesn't really provide important property, but the doc suggests otherwise. This PR removes that part from the doc and also updates the output fields snippets to make it more clear.

@eliangcs eliangcs requested a review from xavdid January 8, 2019 13:57
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! great fix.

@eliangcs eliangcs merged commit 983610e into master Jan 9, 2019
@eliangcs eliangcs deleted the doc-remove-field-important-prop branch January 9, 2019 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants