Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Add per app version helpers #406

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Add per app version helpers #406

merged 5 commits into from
Jun 4, 2019

Conversation

bryanhelmig
Copy link
Member

Adds this cool little feature:

➜  example-app zapier invite
The invitees on your app "Example App" listed below.

Invitees not found. Try adding one with `zapier invite user@example.com`.

You can invite users to this app more broadly by sharing this URL:

  http://localhost:8000/platform/public-invite/2/d33ec180b5796fa90744882c2a3da43b/

You can invite users to each version:

  1.0.0: http://localhost:8000/platform/public-invite/2/1137/b2ddf03f3afba9494ba21cffa4173c48/
  1.0.1: http://localhost:8000/platform/public-invite/2/1138/eb15069071c89e5a6593d7fee7a1f3ac/

Errors running command `zapier init`:

!!!   Missing required positional argument 1/path

For more information, run `zapier help init`. advice.
@bryanhelmig bryanhelmig requested a review from xavdid March 12, 2019 15:14
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

I apparently can't comment on lines that weren't modified, but i'd change the original invite message (_access.js#78) to:

You can invite users to all versions of this app (current and future) using this URL:

to help differentiate why each section is different.

CHANGELOG.md Outdated
@@ -2,6 +2,19 @@

A quick bugfix to resolve a regression

### cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can revert this - we generate this file automatically when we do a release. Also, 8.0.1 is now listed twice

@xavdid
Copy link
Contributor

xavdid commented May 29, 2019

@bryanhelmig is this still relevant? I'm closing out or merging old PRs as possible. We should close or merge this as appropriate!

@bryanhelmig
Copy link
Member Author

No reason this can't merge as is, just forgot about it!

@xavdid xavdid merged commit 1cbf02e into master Jun 4, 2019
@xavdid xavdid deleted the add-per-app-version-helpers branch June 4, 2019 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants