This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Default File Hydrator is a function that we inject to the app definition at runtime. It was added in PR #112 to power the newly-introduced
z.dehydrateFile
method. When a dev callsz.dehydrateFile(url, request, meta)
, they're doingz.dehydrateFile(hydrators.zapierDefaultHydrator, { url, request, meta })
essentially.What This PR Fixes
The
request
andmeta
argument inz.dehydrateFile(url, request, meta)
are optional. When a dev omitsrequest
argument, i.e.,z.dehydrateFile(url)
, we should include the user's auth info when we make the request tourl
. On the other hand, ifrequest
argument is provided, we should not include the user's auth info. This is to make the behavior consistent with the Web Builder as described in this doc.There's a doc change in PR zapier/zapier-platform-cli#360 you may want to take a look at: zapier/zapier-platform-cli@ff79a04.