fix regression where env is ignored

[xavdid]

Ok! So this fixes https://github.com/zapier/zapier/issues/26273. The root issue was that the early require(appPath). Imagine you have the following:

// app/index.js
module.exports = {
  // ... whatever
  url: `${process.env.BASE_URL}/oauth`,
}

when you require('./app'), process.env.BASE_URL is evaluated. The only problem is, the env being passed into lambda from the server isn't merged into process.env until this line, so app.url is undefined/oauth. When it's required again as part of loadApp further down, the result is cached. So even though process.env.BASE_URL exists, the url is wrong.

I read carefully through everything the http patch does and moving it further into that method should have no ill effects (since nothing between its original and new position can use the http module). All the tests are passing as well. I also tested locally and the current env pops up as expected.

I tried the following in loadApp, but weirdly, it didn't work. I had sunk enough time into this as is, so I didn't dig much further after confirming the fix itself.

delete require.cache[require.resolve(appRawOrPath)]; // always get a fresh copy of the app
return resolve(require(appRawOrPath));

[codebycaleb]

I love when really complex problems (env is being ignored in a very specific set of circumstances) have simple solutions (move the skipHttpPatch handling). 😁 Thanks for nailing this one down!

[stevelikesmusic]

Nice find @xavdid! All looks good 👍