Allow file stashing within a create/action #45
Conversation
| @@ -110,7 +110,7 @@ describe('file upload', () => { | |||
| .catch(done); | |||
| }); | |||
|
|
|||
| it('should fail if not being called from an hydrator event', (done) => { | |||
| it('should fail if being called from a trigger event', (done) => { | |||
There was a problem hiding this comment.
Looks good! Please consider adding a test for a search (and maybe passing ones for hydration and create) since you're being specific here.
src/tools/create-file-stasher.js
Outdated
| const isRunningOnHydrator = _.get(input, '_zapier.event.method', '').indexOf('hydrators.') === 0; | ||
| if (!isRunningOnHydrator) { | ||
| return ZapierPromise.reject(new Error('Cannot stash files outside an hydration function/method.')); | ||
| const isRunningOnHydratorOrCreate = () => { |
There was a problem hiding this comment.
This looks good! I'd suggest considering keeping isRunningOnHydrator and adding a isRunningOnCreate, then you can do the check with if (!isRunningOnHydrator && !isRunningOnCreate). I think it might become more clear and easier to add a isRunningOnSearch later if we find it necessary. Again, no need to take the suggestion!
There was a problem hiding this comment.
Great idea - done!
|
@BrunoBernardino Can you double check things, and see if it looks all-clear for merging? |
|
Oh, and please don't release a new version after merging this. I'm expecting to ship other things this week and will take care of releasing a new version with these changes included this week or next. |
Needed for situations where an action/create receives the file's contents from the API/endpoint, and needs to stash that for use in future Zap steps.