This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
Use unsafe data when logging to stdout #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanhelmig
approved these changes
Oct 5, 2017
|
@BrunoBernardino any thoughts on a test for this before I merge? |
|
Awesome stuff @FokkeZB ! I'd just add a test to make sure we're logging the data censored (if there isn't one already). The uncensored version is harder and less important to test for, since it should happen on console. Does that make sense? |
|
@BrunoBernardino we have existing tests for that which still pass so 👍 |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
zapier test --debugit can be very frustrating to have censored logs and IMHO as long as no hacker is peeking over your shoulder we should be fine logging unsafe data to the console.I'm not sure if we can also use unsafe data for
options.logBuffer && data.log_type === 'console'at https://github.com/zapier/zapier-platform-core/pull/50/files#diff-0936f4d83f660e8d3b1ba19e2225e4c6R114.I'm also not sure how to best test this. Can we capture stdout in a test to verify it's unsafe?