[MAJOR] Remove bundle.environment

[xavdid]

It's been deprecated since the first release, so it's a good a time as any to clean it out and make everything a little more consistent.

It should be noted that I haven't been able to test this directly. It turns out it's a bear to build a zip with a different version of core in it (probably a good thing).

Anyway, the reason I think this is fine is because I've got an app that's been running an app in production that uses an environment variable but that value isn't present in the bundle:

% zapier env 1.0.0
The env of your "Steam" listed below.

┌─────────┬───────────────┬──────────────────────────────────┐
│ Version │ Key           │ Value                            │
├─────────┼───────────────┼──────────────────────────────────┤
│ 1.0.0   │ STEAM_API_KEY │ 8D5A1E0...                       │
└─────────┴───────────────┴──────────────────────────────────┘

│     Log       │ { inputDataRaw: {},                                  │
│               │   meta:                                              │
│               │    { frontend: false,                                │
│               │      standard_poll: true,                            │
│               │      prefill: false,                                 │
│               │      test_poll: false,                               │
│               │      limit: -1,                                      │
│               │      hydrate: true,                                  │
│               │      first_poll: false,                              │
│               │      page: 0 },                                      │
│               │   authData: { steamid: ':censored:15:d607b82756:' }, │
│               │   inputData: {},                                     │
│               │   environment: {} }

the http logs are free of errors, which would only be the case if the api key was correctly set in the environment.

[xavdid]

Ok! I've confirmed this works.

│     Log       │ { inputDataRaw: {},                                  │
│               │   meta:                                              │
│               │    { frontend: false,                                │
│               │      standard_poll: true,                            │
│               │      prefill: false,                                 │
│               │      test_poll: false,                               │
│               │      limit: -1,                                      │
│               │      hydrate: true,                                  │
│               │      first_poll: false,                              │
│               │      page: 0 },                                      │
│               │   authData: { steamid: ':censored:15:d607b82756:' }, │
│               │   inputData: {} }                                    │
│     Version   │ 1.0.0                                                │
│     Step      │ 740e12ab-cdee-4946-b300-6c9c09cfa241                 │
│     Timestamp │ 2018-03-09T15:46:23-06:00

[eliangcs]

I'm giving a 👍in advance, but I don't have historical context about this change. Can you write a little bit more about what event.bundle.environment was and why it was there?

[xavdid]

this actually predates me too! @bryanhelmig might have context. The initial public commit had it marked as deprecated. It seems like they were originally going to pipe the env into the bundle but instead went with it as a proper env variable.

Either way, i'm pretty sure it's vestigial now.