(docs) be more clear about whether hook methods are required #58

xavdid · 2018-10-31T22:27:15Z

Adds a doc annotation to make the hook implementation requirements more clear. Fixes zapier/zapier-platform-cli#364.

@arkwright, if you want to peek / have feelings about it

eliangcs

Thanks for addressing the confusion! Only got one suggestion. The diff in package-lock.json may come from an old version of npm. Can you upgrade npm and rerun npm install to get rid of the diff in package-lock.json?

xavdid · 2018-11-01T14:44:46Z

That's weird. We don't even need a lockfile change here, i just needed to install. i'll pull it from the PR entirely.

be more clear about whether hook methods are required

2d6d0ee

xavdid requested a review from eliangcs October 31, 2018 22:27

xavdid changed the title ~~be more clear about whether hook methods are required~~ (docs) be more clear about whether hook methods are required Oct 31, 2018

eliangcs approved these changes Nov 1, 2018

View reviewed changes

reset package-lock.json

d2febb3

xavdid merged commit ca8d3e1 into master Nov 1, 2018

xavdid deleted the hook-operation branch November 1, 2018 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(docs) be more clear about whether hook methods are required #58

(docs) be more clear about whether hook methods are required #58

xavdid commented Oct 31, 2018

eliangcs left a comment

xavdid commented Nov 1, 2018

(docs) be more clear about whether hook methods are required #58

(docs) be more clear about whether hook methods are required #58

Conversation

xavdid commented Oct 31, 2018

eliangcs left a comment

Choose a reason for hiding this comment

xavdid commented Nov 1, 2018