move commands to yarn #1
Conversation
| # End of https://www.gitignore.io/api/node | ||
|
|
||
| packages/examples/*/yarn.lock | ||
| packages/examples/*/package-lock.json |
There was a problem hiding this comment.
we didn't have lockfiles in the old example apps, so I figured we shouldn't here either
There was a problem hiding this comment.
That would mean the entire monorepo wouldn't have a lockfile? That makes me a little nervous. Does this .gitignore get applied to all example apps?
There was a problem hiding this comment.
nope, the monorepo itself will still have a lockfile checked in! this only affects stuff down in the examples directory, where we don't want to push users either way.
| "add": "git add exported-schema.json README.md docs", | ||
| "precommit": "npm run build && npm run add && lint-staged" | ||
| "build": "yarn docs && yarn export", | ||
| "git-add": "git add exported-schema.json README.md docs", |
There was a problem hiding this comment.
this is the only command that actually changed names
| # End of https://www.gitignore.io/api/node | ||
|
|
||
| packages/examples/*/yarn.lock | ||
| packages/examples/*/package-lock.json |
There was a problem hiding this comment.
That would mean the entire monorepo wouldn't have a lockfile? That makes me a little nervous. Does this .gitignore get applied to all example apps?
| "scripts": { | ||
| "preversion": "git pull && npm test", | ||
| "version": "node bin/bump-dependencies.js && npm install && git add package.json package-lock.json", | ||
| "version": | ||
| "node bin/bump-dependencies.js && npm install && git add package.json package-lock.json", |
There was a problem hiding this comment.
Do we want to use yarn in this script?
| "/lib/**/*.js", | ||
| "/schema.js" | ||
| ], | ||
| "files": ["/exported-schema.json", "/lib/**/*.js", "/schema.js"], | ||
| "scripts": { | ||
| "preversion": "git pull && npm test", |
There was a problem hiding this comment.
Should we use yarn test?
|
Re the multiple lock files, there should only be one at the root of the project (cf. Yarn workspaces). I'm not exactly sure how Yarn behaves with one lock file per workspace. |
Swap commands to use
yarninstead ofnpm.the only substantive change here is that instances of
npm run xhave swapped toyarn x. There's also one command that's been renamed since it conflicts with the already existingyarn add.