refactor(cli) port convert command #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Looks great! Should be good to merge once the description is fixed. While you're there, you probably want to update the Node version in package.json too.
| * \`Noun\` -- your action's noun | ||
| * \`Label\` -- your action's label | ||
| * \`Resource\` -- the resource (if any) this action is tied to | ||
| * \`Available Methods\` -- testable methods for this action`; |
There was a problem hiding this comment.
Looks like the description here is for zapier describe instead of zapier convert?
There was a problem hiding this comment.
ah, good call! that's what happens what i'm doing so many of these in a row 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last command that needed porting! it also adds some extra error handling around invalid inputs (such as trying to convert a CLI app)