fix(cli) Allow env variables containing equals

[robwa10]

fix(cli): Correctly parse out env variables that contain an equal sign

Fixes a bug where we don't correctly parse env variables that contain an equal sign as part of the variable. An equal sign is a valid special character and occurs reasonably often in things such as CLIENT_SECRETS, etc. This seems to be a regression as the previous env command didn't parse those incorrectly.

[xavdid]

Nice!

I tested a little bit and found that this wouldn't work for multiline values (such as public keys). Rather than chase down every possible valid value with a regex, I'd suggest the following:

const [key, ...valueParts] = kvPair.split('=')
const value = valueParts.join('=')

When run with your test, we get

> key
'SECURE_KEY'
> valueParts
[ '8n*e9!', '92g' ]

This'll work with any number of equals in the value and avoids the regex and the unusual .split call. Also plays nice with whatever is otherwise valid in the value. How does that sound?

[robwa10]

Ah, yes, spread syntax. I knew there was a more concise way forward here! Also, never considered multi-line inputs like public keys so a great catch there. 👍

[xavdid]

cool! feel free to merge at your leisure.

[robwa10]

@xavdid Github doesn't trust me...to be fair I've given them some good reasons early on in my Github experiences... 😂

[xavdid]

odd! I'll merge it and take a closer look at why you can't