-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(core, cli, schema) Update deps, drop support for Node versions older than 10 #218
Conversation
@@ -3,3 +3,4 @@ package.json | |||
package-lock.json | |||
packages/cli/snippets/next.js | |||
packages/cli/src/generators/templates/ | |||
.yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier
was hanging for a long time on my first pre-commit because it was trying to prettier all of yarn
🙈
}, | ||
"workspaces": [ | ||
"packages/*", | ||
"example-apps/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think we need to include these anymore.
], | ||
"*.{js,json}": [ | ||
"prettier --write", | ||
"git add" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer version of lint-staged
handles git add
for us, so the docs said to remove it.
const mockUpload = bodyMatcher => { | ||
nock('https://s3-fake.zapier.com') | ||
.post('/', bodyMatcher) | ||
.reply(204, ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the ''
was the only actual change here. That's the default in nock
now, so I didn't figure we needed it.
We can't bump I remember that we're doing something sort of unusual w/ our jsonschema (that was what was originally blocking the work to turn the schema into a typescript def), so we'll leave it where it is for now. |
ok, tests look ✅, I feel good about it. feel free to merge this if you're 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good!
Hi @xavdid and company, I released I'm curious, would you be able to point me to the code where you're validating a property somewhere up the prototype chain? |
Hey @awwright, appreciate the follow-up! I just tried it and it looks like 1.2.8 doesn't fix the change introduced in I wouldn't worry about it too much on your end- it's not critical that we keep the latest version of If you do want to play around, you can reproduce like so:
Tests pass using |
This PR is a result of me running
yarn upgrade-interactive --latest
repeatedly until everything was where I wanted it.I largely left
legacy-scriptring-runner
aloneI changed all our root devDeps to lock to the major version. This will let us update more often and since they're the dev deps, it's less important that we ship an exact version. This means we have to trust folks not to break semver, but we mostly use bigger projects, so i'm not too worried. This will let us run
yarn upgrade
periodically and it'll update all our devDeps for us.Oh, and I took your advice and locked
yarn
onto a specific version. It does that by downloading the entire thing in a single file and then we check it in. That's why the diff is so huge.