Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): include deasync Node 10 binding in the built zip #244

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix(cli): include deasync Node 10 binding in the built zip #244

merged 1 commit into from
Jul 8, 2020

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Jul 8, 2020 •
edited
Loading

A developer on CLI v10 can still use Core v9.x for their app. This is especially true for converted apps. Apps on Core v9.x run on Node 10, so we need to make sure to include the deasync Node 10 binding file in the built zip.

@eliangcs eliangcs requested a review from xavdid as a code owner July 8, 2020 03:19
xavdid
xavdid approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. We keep running into these, when moving across node versions. I'm not sure we'll have a permanent solution unless we use make them available in an AWS layer or something ourselves.

@eliangcs eliangcs merged commit 658171f into master Jul 8, 2020
@eliangcs eliangcs deleted the include-deasync-node-10-binding branch July 8, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliangcs @xavdid