Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): clarify auth refresh breaking change on v10 #246

Merged
merged 7 commits into from
Jul 17, 2020
Merged

fix(core): clarify auth refresh breaking change on v10 #246

merged 7 commits into from
Jul 17, 2020

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Jul 16, 2020 •
edited

This PR turns out to be a little miscellaneous (sorry):

  • Update the changelog and docs to mention the v10 breaking change about the Session and OAuth2 refresh
  • Update session and oauth2 templates so that they don't use a custom afterResponse to handle bad requests (as it's no longer necessary on v10)
  • While I was there, I found oauth1-trello template wasn't working. This PR also fixes it.

Closed PDE-1544.

@eliangcs eliangcs requested a review from xavdid July 16, 2020 07:26
@eliangcs eliangcs marked this pull request as ready for review July 16, 2020 07:26
xavdid
xavdid approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this clarifies a lot

@eliangcs eliangcs merged commit a75aa84 into master Jul 17, 2020
@eliangcs eliangcs deleted the v10-auth-refresh branch July 17, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliangcs @xavdid