Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core, schema): [CTO-11] Add docs for under documented callback URL feature. #278

Merged
merged 6 commits into from Oct 7, 2020
Merged

docs(core, schema): [CTO-11] Add docs for under documented callback URL feature. #278

merged 6 commits into from Oct 7, 2020

Conversation

bryanhelmig
Copy link
Member

Adding some more documentation to cover the z.generateCallbackUrl() usage.

@bryanhelmig
Copy link
Member Author

bryanhelmig commented Oct 7, 2020 •
edited

I think I'll need to include something on how to use performResume to handle the bundle.cleanedRequest/bundle.rawRequest/bundle.outputData call to complete a callback resumption.

@bryanhelmig bryanhelmig requested review from xavdid and removed request for xavdid and eliangcs October 7, 2020 20:18
@bryanhelmig bryanhelmig added the documentation Improvements or additions to documentation label Oct 7, 2020
@bryanhelmig
Copy link
Member Author

This just improves the docs, mind giving it a review @xavdid?

xavdid
xavdid approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left some minor doc clarity things, but it looks good.

packages/cli/README-source.md Outdated Show resolved Hide resolved
packages/cli/README-source.md Outdated Show resolved Hide resolved
packages/cli/README-source.md Outdated Show resolved Hide resolved
packages/cli/README-source.md Outdated Show resolved Hide resolved
packages/cli/README-source.md Outdated Show resolved Hide resolved
@xavdid xavdid changed the title workType(docs): [CTO-11] Add docs for under documented callback URL feature. docs(core, schema): [CTO-11] Add docs for under documented callback URL feature. Oct 7, 2020
@bryanhelmig bryanhelmig merged commit e21be56 into master Oct 7, 2020
@bryanhelmig bryanhelmig deleted the add-callback-docs branch October 7, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees

@xavdid xavdid

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryanhelmig @xavdid