docs(cli): add warning if user counts are still being calculated #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
reviewed
Jan 28, 2021
|
|
||
| if (versions[0].user_count === null) { | ||
| this.warn( | ||
| 'User counts are still being calculated - run this command again in ~10 seconds (or longer if your integration has lots of users).' |
There was a problem hiding this comment.
The user count for each version is calculated independently, so it's possible that some versions have the count while some others don't.
So instead of only checking the first version, we should check all the versions. If there's any version having a null user_count. We should show this warning.
Also, I'd probably say "Some user counts are still being calculated" to avoid any confusion.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PDE-1944