Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralize husky code #34

Merged
merged 2 commits into from
Jul 15, 2019
Merged

centralize husky code #34

merged 2 commits into from
Jul 15, 2019

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Jul 12, 2019

The actual content of this is:

  • remove prettier from devDeps (stays in cli since it's used in scaffold)
  • remove husky, lint-staged, and their configuratioon from all packages
  • per the docs, only run husky in the root.

the exported schema json got run through prettier again and the formatting changed. we jumped a number of minor versions, so something must have changed. In any case, stepped through the command and confirmed that what's in this PR is the output of prettier v1.18.2, so ¯\_(ツ)_/¯

@xavdid xavdid requested a review from eliangcs July 12, 2019 22:54
@xavdid
Copy link
Contributor Author

xavdid commented Jul 12, 2019

Build is failing because yarn is complaining about an incompatible version, which must have come in from an updated dependency.

I ran yarn --ignore-engines locally on node 8 and all the tests passed with no issue.

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up!

Looks like execa requires Node.js >= 8.12 only because here it uses until.getSystemErrorName, which isn't available until Node.js 8.12. I guess it's safe to ignore. Can you add --ignore-engines to the test command(s) accordingly so the tests can be run on CI? Feel free to merge once addressed.

@xavdid
Copy link
Contributor Author

xavdid commented Jul 15, 2019

sweet, that did it! also needed to add AWS_SECRET_ACCESS_KEY=fake (same for secret) on the repo settings. It was doubly confusing because there's 2 identical settings pages (travis-ci.org and .com), but only one affects builds (.com). Got it now though!

@xavdid xavdid merged commit 6320872 into master Jul 15, 2019
@xavdid xavdid deleted the update-husky branch July 15, 2019 17:10
@eliangcs
Copy link
Member

@xavdid that was my bad. I actually removed the ones on travis.com as I thought they're useless. Anyway, I think it's better to put the keys in package.json rather than on Travis. Addressed in #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants