BREAKING CHANGE(core) run apps using node 14 #350
Conversation
boilerplate/scripts/build.sh
Outdated
| # the node-X segment in the next line should match the latest major version | ||
| zip -R $TARGET_FILE '*.js' '*.json' '*/linux-x64-node-10/*.node' '*/linux-x64-node-12/*.node' | ||
| # the node-X segment in the next line should match all supported node versions | ||
| zip -R $TARGET_FILE '*.js' '*.json' '*/linux-x64-node-12/*.node' '*/linux-x64-node-14/*.node' |
There was a problem hiding this comment.
Probably in a separate PR, we'll need to bump deasync in legacy-scripting-runner/package.json. The current version of deasync we're using doesn't have a Node 14 binary.
Also, as my other comment suggests, should we keep Node 10?
There was a problem hiding this comment.
yeah, I'll grab that in my big update everything
| @@ -159,7 +159,7 @@ const forceIncludeDumbPath = (appConfig, filePath) => { | |||
| return ( | |||
| filePath.endsWith('package.json') || | |||
| filePath.endsWith('definition.json') || | |||
| filePath.endsWith(path.join('bin', 'linux-x64-node-10', 'deasync.node')) || | |||
| filePath.endsWith(path.join('bin', 'linux-x64-node-12', 'deasync.node')) || | |||
There was a problem hiding this comment.
Not sure if I understand AWS Lambda runtime support policy correctly. It seems Node.js 10 could still be running after it is deprecated on May 28. Does that mean we should keep both Node 10 and 12 here?
There was a problem hiding this comment.
Good question! so my understanding of how this works is that functions will keep running, but at some point we won't be able to update them anymore. This has mostly been fine for us, since a lot of our functions are long-lived.
But, that does mean if we update boilerplates on godzilla apps anytime after may, we'll need to also bump their node versions (and by extension, their platform versions). though, I suppose we could be building a new boilerplate between merging this and upgrading node. It's probably safest to include as many node binaries as we can, I can't imagine they're that big. I can tweak this and the other spot.
|
I've updated! This binary and version stuff is getting a little confusing, even for me 😅 |
I figured I'd do a dep update in a separate PR.
Also, I think we can take advantage of the travis build matrix feature to more cleanly declare our tests. On each of 12 and 14, run each of
testandsmoke test. I know you mentioned travis being slow; i'm not sure this will help a lot, but it'll at least clean up that file.