Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix finding callback url in event correctly #36

Merged
merged 1 commit into from Jul 17, 2019
Merged

fix finding callback url in event correctly #36

merged 1 commit into from Jul 17, 2019

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Jul 16, 2019

For callbacks to work, we need to pull the callback_url out of the event (see here. There was a typo that prevented this from working as expected.

@xavdid xavdid added the bug Something isn't working label Jul 16, 2019
@xavdid xavdid requested a review from eliangcs July 16, 2019 22:43
@xavdid xavdid added the core label Jul 16, 2019
eliangcs
eliangcs approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xavdid xavdid merged commit e8d4fc5 into master Jul 17, 2019
@xavdid xavdid deleted the callback-bugfix branch July 17, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs eliangcs approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xavdid @eliangcs