Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): skip checking keys on fields without key properties #376

Merged
merged 1 commit into from
May 19, 2021

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented May 19, 2021

Fixes #375 (and PDE-2410)

@xavdid xavdid requested a review from eliangcs as a code owner May 19, 2021 00:13
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@xavdid xavdid merged commit 1e40d32 into master May 19, 2021
@xavdid xavdid deleted the PDE-2410 branch May 19, 2021 03:44
@eliangcs
Copy link
Member

@xavdid we'd want to cut a release for this because the issue is blocking developers from using CLI 11.x. I'll do that next week if you don't have time this week.

@xavdid
Copy link
Contributor Author

xavdid commented May 27, 2021

Yeah good memory! I want to see if there's any other little bug fixes we can get in there. I'll look through issues tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions schema validation failure in v11.0.0
2 participants