fix(core): handle nullish values in auth data #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
commented
Sep 20, 2021
| (item) => !isUrl(item) || isUrlWithSecrets(item) | ||
| ); | ||
| const sensitiveAuthData = recurseExtract(authData, (key, value) => { | ||
| if (isUrl(value) && !isUrlWithSecrets(value)) { |
There was a problem hiding this comment.
logic is the same, but this felt more readable.
| @@ -153,7 +153,7 @@ const flattenPaths = (data, { preserve = {} } = {}) => { | |||
|
|
|||
| // A simpler, and memory-friendlier version of _.truncate() | |||
| const simpleTruncate = (string, length, suffix) => { | |||
| if (string === undefined) { | |||
| if (string == null) { | |||
There was a problem hiding this comment.
this now returns for null and undefined; before we were converting null to '', which was weird.
| @@ -288,7 +288,7 @@ describe('logger', () => { | |||
|
|
|||
| // this test fails because the function that creates the sensitive bank doesn't | |||
| // recurse to find all sensitive values | |||
| it.skip('should replace sensitive data that nested', () => { | |||
eliangcs
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PDE-2771
Secret scrubber only takes a
(string | number)[], so we have to filter out nullish values before they go in. Secret scrubber'srecruseExtractdoes this, but only if we use it!Tests won't pass until zapier/team-developer-platform/secret-scrubber-js!3 is merged.