fix(core): handle case where scriptingSource is an empty string #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
commented
Jan 21, 2022
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| - At runtime, a developer's `perform` function is invoked with the following signature: `perform(z, bundle)`. | |||
| - The `z` object is a collection of functions used commonly by developers and is defined in `core/src/tools/create-lambda-handler.js` | |||
| - Its functions are either Zapier-specific (such as `z.cursor` and `z.dehyrate`) or wrappers around common JS functionality (such as `z.JSON.parse` and `z.console.log`) with better error handling or extra logging | |||
| - Its functions are either Zapier-specific (such as `z.cursor` and `z.dehydrate`) or wrappers around common JS functionality (such as `z.JSON.parse` and `z.console.log`) with better error handling or extra logging | |||
| @@ -8,8 +8,11 @@ const semver = require('semver'); | |||
| const createLegacyScriptingRunner = (z, input) => { | |||
| const app = _.get(input, '_zapier.app'); | |||
|
|
|||
| let source = | |||
| _.get(app, 'legacy.scriptingSource') || app.legacyScriptingSource; | |||
| // once we have node 14 everywhere, this can be: | |||
There was a problem hiding this comment.
Node 12 is EOL may 2022, so not too long!
|
re: failing tests, I was looking at them today and they all passed normally on node 12 & 14 on my local. Maybe GH actions is slower and needs a bigger timeout? Each failing run, it's been a different combination of test & node version failing, so maybe we're just getting unlucky. None of the other tests take near 2 min, but it's possible there's a lot of variance there? |
eliangcs
approved these changes
Jan 27, 2022
|
Regarding the test timeout, I guess the jobs are more likely to timeout when they are run in parallel on GitHub Actions. And I agree, we could try a bigger time limit first. |
xavdid
added a commit
that referenced
this pull request
Jan 27, 2022
eliangcs
added a commit
that referenced
this pull request
Feb 3, 2022
fix(legacy-scripting-runner): backport #475; handle empty scripting string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle a rare case where
legacy.scriptingSourceis an empty string on a legacy app, so we don't initialize LSR. Then,z.legacyScripting.run(...)fails w/Cannot read property 'run' of undefined.