Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(core): bump core deps, drop node 6 support #54

Merged
merged 2 commits into from Aug 27, 2019

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Aug 26, 2019

Actual user impact here should be minimal, but should be noted. sparknotes:

  • response.text() will assume and always use utf-8 encoding. Use response.textConverted() if you want to retain the old behavior (where the library would try and guess)
  • Some internal methods were hidden. If you're not calling response._SOMETHING, then you're fine
  • behavior around comma-separated headers changed. This is the most likely source of a user issue.

read more about the changes in fetch.

@xavdid xavdid requested a review from eliangcs August 26, 2019 21:37
@xavdid xavdid changed the title BREAKING-CHANGE(core): bump core deps, drop node 6 support BREAKING CHANGE(core): bump core deps, drop node 6 support Aug 26, 2019
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for the clear TLDR! So those are breaking changes because of node-fetch. How about Node 6 support? We're dropping Node 6 support because of a certain package upgrade, I presume?

@xavdid
Copy link
Contributor Author

xavdid commented Aug 27, 2019

I think the only thing that is actually unsupported is dotenv, but given core won't be run in node 6 anymore anyway, I think it's mostly ceremonial. ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants