PDE-3251 fix(core): abort logger connection at the end of invocation #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
changed the title
|
I'm no Node expert so forgive me if I'm totally wrong here, but would we want to pass a value for the Edit: this comment was from @robgolding! |
|
@zapzap (not sure who you are) that makes sense. In the latest commits, apart from fixing a test, I've made the time limit default to 200 ms, so the server has a chance to close the connection for us. |
eliangcs
commented
Jul 11, 2022
| err, | ||
| 'http options:', | ||
| httpOptions | ||
| ); |
There was a problem hiding this comment.
I'm removing httpOptions from the log because there were credentials in the AWS logs.
benzapier
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where a Lambda invocation can take ~1 minute before a
socket hang uperror with the log server shows up.You can find the steps to reproduce the error on Slack.
I’m not sure under what situations the log server would stop responding to an open connection on production. (Maybe the log server sometimes crashes?) But we should at least make the core more resilient and not affected by a hanging connection.
The idea is to limit the wait time for the log server to respond. We use node-fetch to make requests to the log server. And to abort a node-fetch request, we can use AbortController. See node-fetch's README for example. Since AbortController only became natively supported on Node.js 15+, I'm using the node-abort-controller package.