Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add saml support #61

Merged
merged 3 commits into from Sep 20, 2019
Merged

feat(cli): add saml support #61

merged 3 commits into from Sep 20, 2019

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Sep 3, 2019

Duplicates zapier/zapier-platform-cli#420. The salient change is that users can paste a deploy key instead of typing an email or password. if we know they're a SAML user based on their email, we can force them into that flow. Otherwise, the experience is the same.

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it works perfectly! Have a suggestion. Feel free to merge once addressed.


const isSamlEmail = async email => {
const rawResponse = await fetch(
`https://zapier.com/api/v4/idp-discovery/?email=${encodeURIComponent(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably use BASE_ENDPOINT here too.

@xavdid xavdid merged commit 2399c5f into master Sep 20, 2019
@xavdid xavdid deleted the saml-login branch September 20, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants