Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE-3242 - feat(schema) Add enablePkce to OAuth2Config #623

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

standielpls
Copy link
Contributor

Adds a new option to the OAuth2Config: enablePkce.
This option will be read by the Zapier Platform backend to use PKCE for the authorization/access token exchange request flow. If this option is not provided, it will default to use the existing OAuth2 flow.

@gregilo
Copy link
Contributor

gregilo commented Feb 20, 2023

@standielpls This is backwards compatible, right? As in, end-users shouldn't be affected when this is released? (sorry, I'm not super familiar with the schema package yet)

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema change looks good to me! The new enablePkce field is optional, so the change is backward compatible.

I suggest we update the OAuth2 section in the docs too. But you can do it in a separate PR.

@standielpls standielpls merged commit bddc0a6 into main Feb 21, 2023
@standielpls standielpls deleted the pde-3242/update-oauth2config branch February 21, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants