Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema) - Add support for throttle configuration #709

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

kola-er
Copy link
Contributor

@kola-er kola-er commented Oct 3, 2023

Adds the optional throttle configuration object to both AppSchema and BasicOperationSchema.

Ticket: https://zapierorg.atlassian.net/browse/PDE-4295

Copy link
Contributor

@standielpls standielpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice just sone light feedback on the help text descriptions

packages/schema/lib/schemas/ThrottleObjectSchema.js Outdated Show resolved Hide resolved
packages/schema/lib/schemas/ThrottleObjectSchema.js Outdated Show resolved Hide resolved
packages/schema/lib/schemas/ThrottleObjectSchema.js Outdated Show resolved Hide resolved
standielpls
standielpls previously approved these changes Oct 4, 2023
Copy link
Contributor

@standielpls standielpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kola-er
Copy link
Contributor Author

kola-er commented Oct 5, 2023

@standielpls Please, help review the docs I just added in the second commit. Thanks.

@kola-er kola-er merged commit 913a99d into main Oct 5, 2023
13 checks passed
@kola-er kola-er deleted the PDE-4295 branch October 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants